[slimtensor] Add non-owning storage mode for wrapping external memory#16767
Open
Gasoonjia wants to merge 1 commit intogh/gasoonjia/108/basefrom
Open
[slimtensor] Add non-owning storage mode for wrapping external memory#16767Gasoonjia wants to merge 1 commit intogh/gasoonjia/108/basefrom
Gasoonjia wants to merge 1 commit intogh/gasoonjia/108/basefrom
Conversation
Add non-owning constructor to MaybeOwningStorage that allows wrapping external memory without taking ownership. This is needed for from_blob() which creates tensors from user-provided data pointers. Changes: - Add MaybeOwningStorage(device, data, nbytes) non-owning constructor - Add is_owning() method to query ownership mode - Non-owning storage uses no-op deleter so external memory is not freed Differential Revision: [D91202898](https://our.internmc.facebook.com/intern/diff/D91202898/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16767
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 1 Unrelated FailureAs of commit fa49848 with merge base 3512861 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add non-owning constructor to MaybeOwningStorage that allows wrapping
external memory without taking ownership. This is needed for from_blob()
which creates tensors from user-provided data pointers.
Changes:
Differential Revision: D91202898